Use POSIXErrorCode instead of direct errno E constants from wasi-libc
#811
Conversation
|
@swift-ci test |
kateinoigakukun
force-pushed
the
pr-2cef32c5c48a62ff1ed41cd448248092fd3c0bf6
branch
from
bea8dbb to
9532cea
Compare
|
@swift-ci test |
wasi-libc's E constants cannot be imported directly by ClangImporter, so we should use `POSIXErrorCode` from Swift instead.
kateinoigakukun
force-pushed
the
pr-2cef32c5c48a62ff1ed41cd448248092fd3c0bf6
branch
from
9532cea to
c25ca66
Compare
|
@swift-ci test |
kateinoigakukun
changed the title
POSIXErrorCode instead of direct errno E constants from libcPOSIXErrorCode instead of direct errno E constants from wasi-libc
| #if os(WASI) | ||
| // wasi-libc's errno.h constants cannot be directly imported into Swift | ||
| // so we use Swift stdlib's POSIXErrorCode instead | ||
| _EOPNOTSUPP = POSIXErrorCode.EOPNOTSUPP.rawValue |
There was a problem hiding this comment.
This workaround here was put in place because the POSIXErrorCode.EOPNOTSUPP does not exist on platforms like Darwin (likely an oversight / a missing enum case). Does that case actually exist on WASI? If so, we might as well avoid this check entirely and just always evaluate the true branch of the if statement rather than worrying about storing this variable on a per-platform basis.
Also, is this something that can/should be fixed in the WASI overlay? There are a few other places where we use these error code constants that I expect would hit the same issue
There was a problem hiding this comment.
Also, is this something that can/should be fixed in the WASI overlay? There are a few other places where we use these error code constants that I expect would hit the same issue
Good pointing! This reminds me that we already provide errno constant shims in the overlay, and I just realized it missed some of them including EOPNOTSUPP.
So this change should be unnecessary after swiftlang/swift#75671
wasi-libc's E constants cannot be imported directly by ClangImporter, so we should use
POSIXErrorCodefrom Swift instead.